-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swerve simple trajectory update #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this covers all the possibilities...
MM/DD/YY
…am488/SeriouslyCommonLib into SwerveSimpleTrajectory-update
…b.com/Team488/SeriouslyCommonLib into SwerveSimpleTrajectory-update" This reverts commit ea9d1a0, reversing changes made to 574d595.
This reverts commit 574d595.
Changed so that instead of cruising in deceleration, will accelerate to minimize time as well.
GlobalKinematics not working, look into it!
aschokking
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Rong, this is a complicated task you took on and the code looks reasonable to me and is generally well structured.
I didn't deep dive on all the math but mainly had feedback on the naming of some things.
src/main/java/xbot/common/subsystems/drive/SwerveCalculatorNode.java
Outdated
Show resolved
Hide resolved
src/main/java/xbot/common/subsystems/drive/SwerveKinematicsCalculator.java
Show resolved
Hide resolved
src/main/java/xbot/common/subsystems/drive/SwerveKinematicsCalculator.java
Show resolved
Hide resolved
src/main/java/xbot/common/subsystems/drive/SwerveKinematicsCalculator.java
Outdated
Show resolved
Hide resolved
src/main/java/xbot/common/subsystems/drive/SwerveKinematicsCalculator.java
Outdated
Show resolved
Hide resolved
src/main/java/xbot/common/trajectory/SwerveSimpleTrajectoryLogic.java
Outdated
Show resolved
Hide resolved
JohnGilb
pushed a commit
that referenced
this pull request
Jan 18, 2025
Rongrrz
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Option to plug in Kinematic values for the SwerveSimpleTrajectory command
Whats changing?
Questions/notes for reviewers
How this was tested
VIDEO!!!
Demo2.mp4