Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swerve simple trajectory update #485

Merged
merged 33 commits into from
Jan 18, 2025
Merged

Conversation

Rongrrz
Copy link
Contributor

@Rongrrz Rongrrz commented Nov 9, 2024

Why are we doing this?

Option to plug in Kinematic values for the SwerveSimpleTrajectory command

Whats changing?

Questions/notes for reviewers

  • Never tested on actual robot
  • Needs to be cleaned up

How this was tested

  • unit tests added
  • tested on robot

VIDEO!!!

Demo2.mp4

@Rongrrz Rongrrz marked this pull request as ready for review November 27, 2024 18:52
@Rongrrz Rongrrz requested a review from a team as a code owner November 27, 2024 18:52
GlobalKinematics not working, look into it!
@Rongrrz Rongrrz removed the dont merge label Jan 7, 2025
More concise variables names and cleaned comments
Copy link
Contributor

@aschokking aschokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Rong, this is a complicated task you took on and the code looks reasonable to me and is generally well structured.

I didn't deep dive on all the math but mainly had feedback on the naming of some things.

@JohnGilb JohnGilb merged commit 8ae3bcb into main Jan 18, 2025
1 check passed
@JohnGilb JohnGilb deleted the SwerveSimpleTrajectory-update branch January 18, 2025 18:34
Rongrrz added a commit that referenced this pull request Jan 18, 2025
JohnGilb pushed a commit that referenced this pull request Jan 18, 2025
Rongrrz added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants